-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 2.1.0 #38
Update to 2.1.0 #38
Conversation
Hi @VisualMelon, thanks a lot for you job on that. I've used the modifications in your branch to swith to 2.1.0 but it seems that the Legend does not implement Also, let me know if I can help speeding up the move to 2.1.0 |
@BobLd wow, looks like I forgot to add the If you're keen to help, the OP above lists some issues I'd identified, but didn't get around to addressing: any progress on understanding/fixing those would be very welcome, but I'm afraid I really don't have a lot of time at the moment to get stuck into large issues like this. (In aid of future porting while it occurs to me, I think the properties were converted from the WPF version of the same with this VS Find&Replace regex https://gist.github.com/VisualMelon/c03fb801f689ef4786effa34cf5fc6d1 ; changed call-backs were dealt with separately) |
@VisualMelon, thanks a lot for your prompt feedback, that's great! Will test it shortly. I'll have a look at the list above and see what I can do. Thanks again! |
To clarify, the line you removed should be there: hopefully with the I can't find any column examples, and I do seem to be able to pan default axes, so not sure what they were about. I think the issue that was really doing my head in was the crash with Perf does feel terrible; probably best to start by working out when the regression was introduced. |
…uGet package and remove local ref
Regarding the
private void OnSizeChanged(object sender, Size size)
{
if (size.Height > 0 && size.Width > 0)
{
InvalidatePlot(sender is Plot);
}
}
EDIT: Regarding the performance, what you did in #22 indeed increase performance greatly, I would start with that |
Ah, yes. The issues are all with the XAML stuff, of course...:
Re. bar series, it seems to be due the differences between Thanks for pushing your work! We don't want to reference an RC in the final thing, but if Avalonia releases before this that's fine. Re. the local reference, that's fine to change as well, just note that making it local can make debugging easier. |
Missing series is just a small error in
The same issue exists in |
Well spotted, it's fixed in my branch. Thanks for that! Will try to have a look at the other exception (of course no RC in final package by the way) |
@BobLd cool; does it work for you without the |
@VisualMelon, It runs without crashing and I can see the bar charts. I did not add protected Series()
{
eventListener = new EventListener(OnCollectionChanged);
} Let me know if I misunderstood something |
@BobLd no, I think you've understood perfectly. I just tested and your code crashes on my machine; I suppose this must be an inconsistency in some non-deterministic behaviour in the Avalonia property engine. On my machine, without I think we should include the line with a comment explaining this, because it makes it more consistent with
I should sort out a PR to fix the core side of things. (Looking deeper, it's a bit of tangled web; there are other bits that will flatly crash, so it probably won't be a nice simple fix) |
That's very strange! For the records, I'm running the code on a Windows 10 laptop, and yes - it seems your solution is the only one short term. I continue working on the performance side of things in my branch using your PR. e.g. I've created EDIT: Any idea what's the purpose of |
Two problems with this:
I'm trying to work out how to resolve the first by inspecting The second can probably be resolved by only removing axes that are not listed as default axes. Again, this may have some knock-on effects. Fixing either should resolve the no-panning problem; the first should definitely be resolved if possible; the second is also present in |
Update concerning I'm currently working on the Bar series legend exception |
I think I've resolved that last. It looks like I made a similar set of changes in OxyPlot-Contrib a while back, and I've pretty much just copied those. @BobLd I've rebased your stuff into my 2.1 branch (corresponding to this PR): I hope you don't mind? This should make it easier for us to discuss details within the confines of the PR. New XAML issues noticed:
HeatMapDemo seems to work now; not sure what has changed in that regard. Legends are also no longer crashing when toggled with the mouse. |
@BobLd ah, again I meant the XAML None-the-less, thankyou for investigating the weirdness in the The example browser issue should probably be in its own issue if you want to make one, since it is independent of the 2.1 changes. |
I can't see anything wrong with the UserControl demos now, but they don't look like their pictures (I suppose we should update the pictures? (low priority)). Marking that as resolved in the OP. I've fixed |
haha my bad :D And yes, well spotted for the |
@VisualMelon for the polyliine issue, adding the following seems to do the trick: |
@VisualMelon - Fixed PieSeries color issues, problem was in |
@BobLd thanks! (using your fixes over mine) I'm not sure why the |
@VisualMelon My pleasure! I'm working on the performance improvements. I guess the easiest solution would be to always use Also, I think there's an issue in |
@VisualMelon - Issue in |
@VisualMelon - I fixed another issue in see https://github.com/BobLd/oxyplot-avalonia/tree/oxy2.1 |
@BobLd good catch, merged. |
@VisualMelon - I've added |
@BobLd fantastic, that is a massive improvement! Could we change |
@VisualMelon sure, it's now updated |
@BobLd do you have any other perf issues you are looking into? If not, I think this is probably ready for a 2.1.0-Preview1 release to nuget. This will give people a chance to use it and abuse it before we commit to 2.1.0. I'm going to do some testing to see if there is an issue with plots in docks, as we had issues with Wpf in the main repo. |
@VisualMelon I'm good for the moment and I'm happy for you to merge and making the preview1 available 💪 |
2.1.0-Preview1 pushed to NuGet. |
TODO:
CanvasRenderContext
CanvasRenderContext
)AvaloniaExamples
):BarSeriesDemo
HeatMapDemo
UserControlDemos
are brokenPlot
with default axes (e.g.Line and Area
example)There are many changes that will need some time to 'sink in', so I don't think a 2.1.0 release will be viable soon if we want it to be stable, though we should provide a pre-release to get feedback. May be worth releasing a 2.0 version before the update.